Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataset layer visibility toggle button to explore page #619

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Add dataset layer visibility toggle button to explore page #619

merged 3 commits into from
Aug 15, 2023

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Aug 15, 2023 •
edited
Loading

Requested feature from JPL EMIT. The visibiility toggle in this pr is global, not per layer.

@netlify
Copy link

netlify bot commented Aug 15, 2023 •
edited
Loading

✅ Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 8d8d50c
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/64db93d2dfcd4b0008e1ffc0
😎 Deploy Preview https://deploy-preview-619--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here marked this pull request as ready for review August 15, 2023 09:29
danielfdsilva
danielfdsilva approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a quick style change.
Otherwise looks good - a nice temporary fix

@hanbyul-here hanbyul-here merged commit 2926bcd into main Aug 15, 2023
8 checks passed
@hanbyul-here hanbyul-here deleted the feature/layer-toggle-quick branch August 15, 2023 21:56
@hanbyul-here hanbyul-here mentioned this pull request Aug 17, 2023
Merged
danielfdsilva added a commit that referenced this pull request Aug 18, 2023
@danielfdsilva
Version 2.2.0
a5e30a1 
# Changelog

## 🎉 Features
- Add scalebar control
(#614)
- Add data layer visibility toggle control
(#619)
- Add center coordinate control
(#612)
- Add tiler URL control
(#594)

## 🚀 Improvements
- Include dataset title in analysis checkbox
(#611)
- Add coastline to basemap
(#621)

## 🐛 Fixes
- 🦗
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfdsilva danielfdsilva danielfdsilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanbyul-here @danielfdsilva